Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnderwerpObject.onderwerpobjectidentificator help texts are incorrect? #337

Open
stevenbal opened this issue Feb 18, 2025 · 1 comment
Open
Labels
bug Something isn't working triage

Comments

@stevenbal
Copy link
Collaborator

Product versie / Product version

2.5.0 / latest

Omschrijf het probleem / Describe the bug

I might be misunderstanding what an OnderwerpObject is, but from what I understand from the information model it is used to link KlantContacten to objects such as Zaken (https://vng-realisatie.github.io/klantinteracties/informatiemodel/semantisch_model)

In the help text of the identificator fields however, examples are given that refer to a Natuurlijk Persoon (by using BSN)
Image

Also since no enums exist for codeRegister, codeObjecttype and codeSoortObjectId, it is not clear what values those are capable of having

Stappen om te reproduceren / Steps to reproduce

No response

Verwacht gedrag / Expected behavior

I think there should be enums for the mentioned fields, similar to PartijIdentificator:

Image

I'm not sure what the values of those enums should be though, so this is up for discussion

@swrichards
Copy link
Contributor

Looks like it was copy-paste from the partij identificatoren documentation, as I undertand it the purpose is indeed to refer to resources in third-party systems, such as a zaaksysteem. There are not currently many hard constraints on how to do this, but here's one proposal we drafted for pointing to zaken in a ZGW API: Klantinteractie-Servicesysteem/KISS-frontend#808 (comment)

Note that that proposal is just a start, there's more details to flesh out, but in any case, I agree the documentation here is off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
Status: Triage
Development

No branches or pull requests

2 participants