Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mission "recent runs" should list unique runs of missions #341

Open
sqshemet opened this issue Jan 30, 2025 · 0 comments
Open

Mission "recent runs" should list unique runs of missions #341

sqshemet opened this issue Jan 30, 2025 · 0 comments
Labels
bug Something isn't working critical Something needs to get fixed for next deployment

Comments

@sqshemet
Copy link
Collaborator

Describe the bug
The purpose of rerunning a mission is to be able to resend a mission used for a particular purpose without having to redefine all of its parameters again. Most of our missions are generic and can be used for many purposes, a 8-hour deep transit to M1 is not the same is a 30-minute shallow transit to 3km, even if they're both the "transit" mission. Especially for complicated missions, getting all of the params dialed can be a bit of a pain, so it's useful and less error-prone to rerun a previously successful mission.

The current "recent runs" list appears to deduplicate by mission name, if that 8-hour deep transit occurred after the 30-minute shallow transit the deep one is the only one that shows up. We instead want unique runs of missions, i.e. mission name must matches and all waypoint/parameter overrides must match to be deduplicated

This is related to #267 , where waypoint/parameter overrides don't persist on rerun.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Mission, recent runs
  2. See list of missions, apparently deduplicated by name

Expected behavior
"Recent runs" to list unique runs of missions, only deduplicating when mission name matches AND all waypoint/parameter overrides match

Screenshots
Example from Dash 4:

Image

List from the same time on Dash 5. See that there's no second profile station between keepstation and sci2_flat_and_level:

Image

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@sqshemet sqshemet added bug Something isn't working critical Something needs to get fixed for next deployment labels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working critical Something needs to get fixed for next deployment
Projects
None yet
Development

No branches or pull requests

1 participant