Some suggestions re error checking

[tonysutherland]

Firstly, let me thank you for posting this code and providing a very useful little tool to work with vcards and vcf files. Your efforts have been greatly appreciated.
Basically, worked as advertised, except generated various errors when trying to save the vcard files.
This was due to the name of the file being created from the vcard entry - and the particular vcard entries that I had were valid, but they contained a range of additional characters which the operating system (ubuntu) under python would not accept - and an unhandled exception was raised.
All fine.
I then fixed the program to handle my situation, basically by sanitising the creation of the filename under which to save the vcard.
The sanitisation removed invalid characters which would cause a crash, as replace with an underscore.
I also decided to remove spaces and replace with an underscore, since it does make working with the files from the command line a whole bit easier (and it is better for archiving etc etc). Obviously, doing this is optional.
I placed this, as well as defining the vcard file extension as a command line parameter and adding to the name, all in their own function and changed the calls in the main program
I can post the changed program as a pull request if you are interested (if I can work out what to do - never done this before).
Thanks once again.
Tony

[mbideau]

Hey @tonysutherland,

Thank you very much for your feedback, it is very much appreciated ❤️
And yes, please, post a Pull Request, I would be happy to merge it 👍

I have planed to improve the quality of this code (by a lot), it is long overdue, but I still have other projects (that I am currently releasing) that have a higher priority for me.
May be in a few weeks / months.
Your PR would be another steps towards that goal.

Thank you again.

Best regards,

[tonysutherland]

OK, let me try to work out how to do a pull request properly and I will get the code up to you soon. I hope it goes OK - if not, I will let you know.

[mbideau]

Yes, thanks.
In short: click fork, do a git clone, make changes, git commit, git push, click PullRequest 😃