Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip mutation of else T.absurd #1289

Open
rodrigovilina opened this issue Dec 6, 2021 · 1 comment
Open

Skip mutation of else T.absurd #1289

rodrigovilina opened this issue Dec 6, 2021 · 1 comment

Comments

@rodrigovilina
Copy link

rodrigovilina commented Dec 6, 2021

Sorbet declares unreachable else-clauses using a call to T.absurd. This is necessary for sorbet to actually verify all possible types or values have been already checked.

We need to be able to skip the mutations that remove the else branch when it's content is a call to T.absurd, because most of the times there is no practical way to reach it in tests.

case elem # say this is T.any(Integer, String)
when Integer then some
when String then some_other
else T.absurd(elem)
end
@rodrigovilina
Copy link
Author

This is true for both case statements and if statements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant