Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.4 #65

Open
nida-pyramid opened this issue May 20, 2019 · 2 comments
Open

Version 1.4 #65

nida-pyramid opened this issue May 20, 2019 · 2 comments

Comments

@nida-pyramid
Copy link

nida-pyramid commented May 20, 2019

Hi, our project requirement is to use 1.4.1 version, and there I have found a bug.

in file lib/princely/pdf_helper.rb:54

Following method has issue which you guys fixed already in the latest princely version.

Issue: It should do asset.to_s.gsub(".css","")

CURRENT

  def asset_file_path(asset)
    stylesheet = stylesheet.to_s.gsub(".css","")
    File.join(config.stylesheets_dir, "#{stylesheet}.css")
  end

Need to fix this method for version 14.1. Can we change it to below code?

PROPOSED

  def asset_file_path(asset)
    asset = asset.to_s.gsub(".css","")
    File.join(config.stylesheets_dir, "#{asset}.css")
  end

Using for Rails 3.0.0 Version

@nida-pyramid
Copy link
Author

please reply earliest possible

@nida-pyramid
Copy link
Author

Please let me know, How soon we can do that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant