Language negotiation does not support the standard format for country codes (hyphen)

[erdmenchen]

Browsers usually send the Accept-Language-Header with country code in the hyphen notation e.g. de-DE, but the language negotiator only matches against de_DE in the current version of the config file.

laravel-localization/src/Mcamara/LaravelLocalization/LanguageNegotiator.php

Line 63 in bafd681

if ( (isset($locale['regional']) && $locale['regional'] == $key) || (isset($locale['lang']) && $locale['lang'] == $key) ) {

In the current version of the config file all country aware languages are formatted with the underscore character.

laravel-localization/src/config/config.php

Line 38 in bafd681

//'de' => ['name' => 'German', 'script' => 'Latn', 'native' => 'Deutsch', 'regional' => 'de_DE'],

This results in a bad match and the requested language de-DE is not set because it does not match de and it does not match de_DE.

[ansata2001]

Also, there is no the "lang" property in any line of the the bundled config.php https://github.com/mcamara/laravel-localization/blob/master/src/config/config.php although the languageNegotiator is trying to check if it matches with the key. Maybe it makes sense to to add the "lang" property on the fly when doing the negotiation, taking the Locale::canonizalize() of the key? If the property is not set manually.

[ansata2001]

There was an accepted pull request addressing this issue: #507

[erdmenchen]

Thank you very much @ansata2001.
I have not yet tested your fix, but it looks promising what I see in the pull request.