Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be more careful about signed/unsigned comparisons #335

Open
terrillmoore opened this issue Jun 12, 2022 · 0 comments
Open

Be more careful about signed/unsigned comparisons #335

terrillmoore opened this issue Jun 12, 2022 · 0 comments
Assignees
@terrillmoore
Labels
bug

Comments

@terrillmoore
Copy link
Member

gcc -Wall complains about signed/unsigned comparisons. It doesn't hurt to fix these. It requires some verbosity, but isn't generally difficult, and it makes the code more proof-like. This ticket tracks those changes.
@terrillmoore terrillmoore self-assigned this Jun 12, 2022
terrillmoore added a commit that referenced this issue Jun 12, 2022
@terrillmoore
Fix #335: signed/unsigned compare in cDate::isValidYearMonthDay()
3780b1e
terrillmoore added a commit that referenced this issue Jun 12, 2022
@terrillmoore
Fix #335: signed/unsigned compare in cDate::isValidHourMinuteSecond()
01dece0
terrillmoore added a commit that referenced this issue Jun 12, 2022
@terrillmoore
Fix #335: fix warning in cFlash_AT25SF081::SPICLOCK()
34a51a1
terrillmoore added a commit that referenced this issue Jun 12, 2022
@terrillmoore
Fix #335: signed/unsigned nit. Add comments
b9a711a
terrillmoore added a commit that referenced this issue Jun 12, 2022
@terrillmoore
Fix #335: use method instead of direct compare: avoid warnings
92ee590
terrillmoore added a commit that referenced this issue Jun 12, 2022
@terrillmoore
Fix #335: clean up cDate::setGpsTime() [un]signed compares
0108bff
terrillmoore added a commit that referenced this issue Jun 12, 2022
@terrillmoore
Fix #335: fix signed/unsigned compares in cDownload::fsmDispatch()
e29f15e
terrillmoore added a commit that referenced this issue Jun 12, 2022
@terrillmoore
Fix #337: Fix #335: clean up cFlash_AT25SF081::begin()
3ea3e9a
terrillmoore added a commit that referenced this issue Jun 12, 2022
@terrillmoore
Fix #335: -Wtype-limits in cStreamLineCollector
472b892 
We had lots of errors due to our normal range checking; GCC
doesn't like when we say `if (0 <= v && v <= max)` if `v` is unsigned.
The more verbose way of getting the same effect is to add static
asserts using `std::numeric_limits()`.
terrillmoore added a commit that referenced this issue Jun 12, 2022
@terrillmoore
Fix #335: [un]signed cleanup Catena_Mx25v8035f::begin()
6ff9a53
terrillmoore added a commit that referenced this issue Jun 12, 2022
@terrillmoore
Fix #335: fix signed/unsigned warning CatenaStm32L0_ReadAnalog
8ba8c3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terrillmoore terrillmoore

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@terrillmoore