Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust activity decoders so that no activity maps to 0% activity #18

Open
terrillmoore opened this issue Nov 17, 2022 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@terrillmoore
Copy link
Member

Right now, no activity maps to 0.02% activity when the data is passed through the system. This is an artifact of the various scaling conversions. The filter in the 4430 software will settle at a final value (-1) after a short period of inactivity; but for whatever reason, this is transmitted as a value that isn't quite full scale [-1, 1]; subsequent mapping onto [0,100%] is not quite mapping minimum to zero. Probably also not mapping 1 to 100%, but that's not such an observable thing.

Add unit tests that will exercise this, as part of correcting the code.

Since we have many formats, this probably requires searching through all the decoders and test vectors and correcting.

@terrillmoore terrillmoore added the bug Something isn't working label Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants