Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading warning message about unusable space for legacy madm arrays #141

Open
alexsee75 opened this issue Jan 11, 2025 · 2 comments
Open

Comments

@alexsee75
Copy link

In mdadm/Manage.c line #805 there is no check for legacy arrays. For legacy (non-persistent) arrays the restriction to 4TB does not apply, so this warning message should be suppressed in that case (IMHO by adding ... && array->not_persistent == 0 to the condition on the if in that line - but please check, I haven't looked into the code too deeply)

It's a minor issue but likely to confuse those (probably few) people still using legacy mdadm arrays.

@mtkaczyk
Copy link
Member

Hello @alexsee75
Just to be clear, do you mean this check:
https://github.com/md-raid-utilities/mdadm/blob/main/Manage.c#L805

For legacy (non-persistent) arrays the restriction to 4TB does not apply

You are not clarifying why it is not applying. We have super0 and this is super0 limitation, not persistent/not-persistent arrays. Could you please elaborate?

Simply, I don't know this problem :)

@alexsee75
Copy link
Author

alexsee75 commented Jan 27, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants