Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Compatibility with browserify #100

Merged
merged 2 commits into from
Feb 7, 2015

Conversation

pagenoare
Copy link
Contributor

Hey,

I'm using browserify, and would like to use your plugin with it. I've managed to do it with this patches. I haven't done the minification though, I don't know which tool you've been using for that.

Thanks for the plugin!

Regards,
Kacper.

@pagenoare
Copy link
Contributor Author

BTW, I took an idea about changing this to window from Leaflet/Leaflet#1572 .

Also, I've created simple example: pagenoare/browserify-bootstrap-example@dda6192

Regards,
Kacper.

@CWSpear
Copy link
Collaborator

CWSpear commented Feb 7, 2015

I should make a note about minification. Sorry.

So you'll need me to publish this to npm, right? I've never actually used browserify, but that's how it works, correct?

@pagenoare
Copy link
Contributor Author

Yeah, publishing it to npm registry would be slightly cleaner, because then I could change this line: pagenoare/browserify-bootstrap-example@dda6192#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R15

to look like:

    "bootstrap-hover-dropdown": ""

Without putting this into registry (but merging this PR, package.json must be inside repo) this plugin could be also accessed like:

    "bootstrap-hover-dropdown": "CWSpear/bootstrap-hover-dropdown"

Thanks.

@CWSpear CWSpear merged commit 853eb8b into mdbootstrap:master Feb 7, 2015
@CWSpear
Copy link
Collaborator

CWSpear commented Feb 7, 2015

I have published to npm before. But right now, it seems to be down or something? I keep getting publish Failed PUT 500 errors trying to publish. I updated npm, but I wonder if it's related to the node 0.12.0 release.

@CWSpear
Copy link
Collaborator

CWSpear commented Feb 7, 2015

Ah, I figured it out. My login was stale... strange that that resulted in a 500 error (see npm/npm#6669)

Anyway, npm install bootstrap-hover-dropdown away!

@pagenoare
Copy link
Contributor Author

Thanks @CWSpear! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants