Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

afterRemove called when not removed #18

Open
sgbeal opened this issue Apr 6, 2013 · 0 comments
Open

afterRemove called when not removed #18

sgbeal opened this issue Apr 6, 2013 · 0 comments

Comments

@sgbeal
Copy link

sgbeal commented Apr 6, 2013

the afteRemove callback is, quite non-intuitively, called even if the users denies removal via confirm(), and the callback provides no way of telling the client whether or not the element was REALLY removed. This makes it impossible to, e.g., post an AJAX delete-resource request based on the afterRemove callbacking being called (which is what we are trying to do).

To work around this we locally hacked the afterRemove-calling code to pass a second parameter, a boolean telling us whether or not the remove actually happened. This is, however, IMO, not a real solution. IMO the afterRemove should not be called unless something is actually removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant