Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add devlink dpipe, resource and trap constants to golang.org/x/sys/unix #2

Open
kvadrage opened this issue Nov 6, 2019 · 3 comments

Comments

@kvadrage
Copy link

kvadrage commented Nov 6, 2019

Hi @mdlayher !

I'm planning to extend this library to add support for additional devlink features like:

  • devlink dpipe
  • devlink sb
  • devlink resource
  • devlink trap

Already implemented some of them, but there's one issue, that prevents me to move forward with this.

I saw you recently submitted devlink constants definitions into golang.org/x/sys/unix.
However, some of them are still missing, for example:

DEVLINK_ATTR_RESOURCE_*
DEVLINK_ATTR_DPIPE_TABLE_RESOURCE_*
DEVLINK_ATTR_TRAP_*
DEVLINK_ATTR_PARAM_*
DEVLINK_ATTR_INFO_*

I would be grateful if you could add them to unix package as well.
Can you please help?

Regards,
Alexander

@mdlayher
Copy link
Owner

mdlayher commented Nov 7, 2019

I recall having some trouble adding some of the newer constants with the current code generation infrastructure. I'll take another look, but in the mean time, you can always hard code local definitions.

@mdlayher
Copy link
Owner

mdlayher commented Nov 7, 2019

By the way, I'm glad you're adding more features! Thank you. If possible, please keep each commit/PR small in size so it's easier for me to review and offer feedback.

@kvadrage
Copy link
Author

kvadrage commented Nov 8, 2019

Thank you for your feedback!
I will start submitting parts, that could be done with existing constants, and then get back to the ones with missing definitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants