Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the command keys returned by getAll are the currently set #24174

Open
opto opened this issue Feb 5, 2023 · 0 comments · May be fixed by #37763
Open

the command keys returned by getAll are the currently set #24174

opto opened this issue Feb 5, 2023 · 0 comments · May be fixed by #37763
Assignees
Labels
Content:WebExt WebExtensions docs p2 Minor issue with low priority, can be fixed later.

Comments

@opto
Copy link

opto commented Feb 5, 2023

MDN URL

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/commands/Command

What specific section or headline is this issue about?

second sentence in commans section at top

What information was incorrect, unhelpful, or incomplete?

This contains the information specified for the command in the commands manifest.json key.

What did you expect to see?

As for the command keys (maybe also name, not tested), it returns the currently set key combination, not the one from the manifest. So if user changes the keys, the new key combination is returned, which makes sense.

But the MDN text tells differently.

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

No response

MDN metadata

Page report details
@opto opto added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Feb 5, 2023
@github-actions github-actions bot added the Content:WebExt WebExtensions docs label Feb 5, 2023
@rebloor rebloor added p2 Minor issue with low priority, can be fixed later. and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Feb 5, 2023
@rebloor rebloor self-assigned this Jan 22, 2025
@rebloor rebloor linked a pull request Jan 23, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebExt WebExtensions docs p2 Minor issue with low priority, can be fixed later.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants