Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to webpack 5.x #539

Closed
garethbowen opened this issue Feb 22, 2023 · 3 comments · Fixed by #625
Closed

Update to webpack 5.x #539

garethbowen opened this issue Feb 22, 2023 · 3 comments · Fixed by #625
Assignees
Labels
Type: Technical issue Improve something that users won't notice

Comments

@garethbowen
Copy link
Member

garethbowen commented Feb 22, 2023

Describe the issue
Webpack 5 promises to execute faster and produce smaller bundles (though this should be checked with our specific use case) so we should update when possible.

This will also mean we no longer support Node 8, which is ok because it's ancient anyway, but should be a major version change to make the breaking compatibility clear.

At the same time consider dropping support for Node 10, 12, and potentially 14...

@garethbowen garethbowen added the Type: Technical issue Improve something that users won't notice label Feb 22, 2023
@garethbowen
Copy link
Member Author

I gave this a shot, but my very naive approach cause webpack to hang on execution in unit tests without any indication of why or where, so I've backed out for now.

@garethbowen
Copy link
Member Author

Remember to reset the hashFunction as explained in this comment: #540 (comment)

@m5r m5r self-assigned this Jul 22, 2024
@m5r m5r linked a pull request Jul 22, 2024 that will close this issue
@m5r
Copy link
Member

m5r commented Jul 24, 2024

Copy/pasting my comment here for posterity's sake:
The unit tests were hanging because they were mocking timers. Webpack calls setImmediate at some point during the compilation and since it was overridden by the mock, it never called its callback.

@m5r m5r closed this as completed in #625 Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Technical issue Improve something that users won't notice
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants