Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version for the next release (v0.16.0) #440

Merged
merged 3 commits into from
Mar 20, 2024
Merged

Conversation

meili-bot
Copy link
Contributor

This PR is auto-generated.

The automated script updates the version of meilisearch-swift to a new version: "v0.16.0"

@meili-bot meili-bot added the skip-changelog The PR will not appear in the release changelogs label Mar 12, 2024
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

meili-bors bot added a commit that referenced this pull request Mar 12, 2024
440: Update version for the next release (v0.16.0) r=curquiza a=meili-bot

_This PR is auto-generated._

The automated script updates the version of meilisearch-swift to a new version: "v0.16.0"


Co-authored-by: meili-bot <[email protected]>
Copy link
Contributor

meili-bors bot commented Mar 12, 2024

Build failed:

@curquiza
Copy link
Member

bors merge

meili-bors bot added a commit that referenced this pull request Mar 12, 2024
440: Update version for the next release (v0.16.0) r=curquiza a=meili-bot

_This PR is auto-generated._

The automated script updates the version of meilisearch-swift to a new version: "v0.16.0"


Co-authored-by: meili-bot <[email protected]>
Copy link
Contributor

meili-bors bot commented Mar 12, 2024

Build failed:

@Sherlouk
Copy link
Collaborator

All failures appear random.

bors try

meili-bors bot added a commit that referenced this pull request Mar 13, 2024
Copy link
Contributor

meili-bors bot commented Mar 13, 2024

try

Build failed:

@Sherlouk
Copy link
Collaborator

Need to take a look at that "Install MeiliSearch" step, it's constantly causing problems in the automation. Is it similar to other language packages?

@sanders41
Copy link

Need to take a look at that "Install MeiliSearch" step, it's constantly causing problems in the automation. Is it similar to other language packages?

It is not. The other languages uses Docker. But Docker only works on Linux in GitHub Actions.

@curquiza
Copy link
Member

yeah this problem is really random, we never figured out why it happens... sometimes it's impossible to merge for multiple hours, and after it's ok

bors merge

meili-bors bot added a commit that referenced this pull request Mar 14, 2024
440: Update version for the next release (v0.16.0) r=curquiza a=meili-bot

_This PR is auto-generated._

The automated script updates the version of meilisearch-swift to a new version: "v0.16.0"


Co-authored-by: meili-bot <[email protected]>
Copy link
Contributor

meili-bors bot commented Mar 14, 2024

Build failed:

@curquiza
Copy link
Member

Looks like it's impossible now... but we merged this PR last week...
#438 (comment)

@Sherlouk
Copy link
Collaborator

Not suggesting that upgrade hasn't broken something else, but looks extremely unlikely to have made this issue with resolving the MS dependency any worse. It's always been problematic as far as I can see, just now even more so...

Maybe hitting some weird rate limits?

@curquiza
Copy link
Member

Maybe hitting some weird rate limits?

This was our first thought. That's why we use this env variable to increase the rate:

GITHUB_PAT: ${{ secrets.MEILIBOT_PAT_REPO }}

@sanders41
Copy link

I would guess that it isn't a GitHub Actions rate limit issue because the install script downloads successfully, though I could be wrong. The install script uses the GitHub API so possible a rate limit there?

Because the install script shows the same message for multiple failure types (which makes sence for it's main purpose) it isn't possible to tell why it fails. My suggestion would be to either use a custom version of the bash script here that includes more logging, or to update the main script with an option to pass a -v flag to get more verbose output. Then you could add logging to find out where the script fails to narrow down if anything can be done to fix it.

@curquiza
Copy link
Member

bors merge

meili-bors bot added a commit that referenced this pull request Mar 18, 2024
440: Update version for the next release (v0.16.0) r=curquiza a=meili-bot

_This PR is auto-generated._

The automated script updates the version of meilisearch-swift to a new version: "v0.16.0"


Co-authored-by: meili-bot <[email protected]>
Copy link
Contributor

meili-bors bot commented Mar 18, 2024

Build failed:

@curquiza
Copy link
Member

(I tried 😅 )

@sanders41 we already made investigation with bidoubiwa a long time ago: we don't know why but sometime GitHub does not return the release when calling "https://api.github.com/repos/meilisearch/meilisearch/releases/latest"

It was a long time ago so maybe the problem is not the same anymore

@curquiza
Copy link
Member

Hello everyone, I merge this PR manually since tests worked with previous PR

I discussed with @brunoocasali and I will investigate this to fix the problem in the coming weeks. Not my priority but it's in my TODO 😊

@curquiza curquiza merged commit 26f30d1 into main Mar 20, 2024
2 of 6 checks passed
@curquiza curquiza deleted the meili-bot/bump-version branch March 20, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants