Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass sr as keyword at librosa.load #15

Open
progsi opened this issue Nov 1, 2024 · 1 comment
Open

Pass sr as keyword at librosa.load #15

progsi opened this issue Nov 1, 2024 · 1 comment

Comments

@progsi
Copy link

progsi commented Nov 1, 2024

Thanks for the great work of FMP Notebooks and with this package!
I would like to report a small issue in c4s2_ssm.py and possibly other places where librosa.load is used. In newer librosa versions, the sr parameter name must be specified and hence librosa.load does not work.

@progsi progsi changed the title pass Pass sr as keyword at librosa.load Nov 1, 2024
@fzalkow
Copy link
Collaborator

fzalkow commented Nov 8, 2024

Hi Simon, Many thanks for raising this issue.

I wonder, which librosa version you are referring to? The documentation for the latest version (0.10.2) specifies that the audio sample is resampled to 22050 Hz by default. Furthermore, in the current main branch of the librosa Github repository, a default sample rate of 22050 Hz is given.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants