Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle arbitrary URLs from the {% adjust %} template tag #66

Open
harrislapiroff opened this issue Nov 13, 2014 · 0 comments
Open

Handle arbitrary URLs from the {% adjust %} template tag #66

harrislapiroff opened this issue Nov 13, 2014 · 0 comments
Labels

Comments

@harrislapiroff
Copy link
Contributor

As was brought up in #65, Daguerre's {% adjust %} template tag currently does not accept arbitrary URLs to images for adjustment. E.g.,

{% adjust "http://www.wired.com/wp-content/uploads/2014/07/brain1.jpg" 'crop' width=200 height=200 %}

is invalid and will throw an exception. This is something Daguerre could theoretically support.

Pros

  • Other libraries like sorl support it.
  • It's something template designers may occasionally want to do.
  • It would be an easy way of relocating an image from an external server to the current application's media server.

Cons

  • It would encourage template designers to build sites that rely on the responsivity of external image sources.
  • Keeping track of whether an image has already been downloaded and adjusted based on a URL alone could prove tricky or computationally costly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant