Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Meltano section header/footer when uninstalling every entry #8

Open
WillDaSilva opened this issue Sep 15, 2022 · 0 comments
Open

Comments

@WillDaSilva
Copy link
Member

The code that currently handles uninstall --all is:

        if uninstall_all:
            # XXX: This leaves behind the "begin/end Meltano section" comments
            predicate = lambda _: True

There is no special case in the setter for entries (or the setter for crontab) that removes the header and footer when no entries remain.

@WillDaSilva WillDaSilva self-assigned this Sep 15, 2022
@WillDaSilva WillDaSilva changed the title Remove Meltano section header/footer when uninstall every entry Remove Meltano section header/footer when uninstalling every entry Sep 23, 2022
@WillDaSilva WillDaSilva removed their assignment Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant