Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Allow plugins to declare a default command #102

Open
aaronsteers opened this issue Aug 8, 2022 · 3 comments
Open

Feat: Allow plugins to declare a default command #102

aaronsteers opened this issue Aug 8, 2022 · 3 comments

Comments

@aaronsteers
Copy link
Contributor

Currently if there is no command specified in meltano run or meltano invoke, meltano will use the executable at the plugin level.

Context

For the new plugin SDK, we want to be able to have a passthrough so that meltano invoke my-dbt run "just works" even if the actual syntax is my-plugin invoke run.

We want meltano to run this:

my-plugin invoke run

As a result of us executing this:

meltano invoke my-plugin run

Disambiguation / Pre-Analysis Needed

We should test if a viable alternative would be to have the plugin declare top-level args such as args: invoke, and if that would solve this usage pattern without needing a new feature.

@aaronsteers
Copy link
Contributor Author

@pandemicsyn - This is a follow-up to our conversation. What I don't know is whether we can mitigate by just declaring a default arg of invoke or if that has some other issues which would prevent it from being viable.

@pandemicsyn
Copy link

👍 This seems like it could be a nice UX shortcut to have available, in general. Even without considering what we need on the SDK (which this would also help clean up).

@stale
Copy link

stale bot commented Apr 26, 2023

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

@WillDaSilva WillDaSilva transferred this issue from meltano/meltano May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants