From a93d87b99f209c9f0aaba40bb1a6999ed55bb984 Mon Sep 17 00:00:00 2001 From: Reuben Frankel Date: Tue, 22 Oct 2024 14:07:56 +0100 Subject: [PATCH 1/5] Update to `v0.8.0` https://github.com/Matatika/tap-googleads/releases/tag/v0.8.0 --- _data/meltano/extractors/tap-googleads/matatika.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/_data/meltano/extractors/tap-googleads/matatika.yml b/_data/meltano/extractors/tap-googleads/matatika.yml index 429e2ce7f..ffdd16c9d 100644 --- a/_data/meltano/extractors/tap-googleads/matatika.yml +++ b/_data/meltano/extractors/tap-googleads/matatika.yml @@ -16,7 +16,7 @@ logo_url: /assets/logos/extractors/googleads.png maintenance_status: active name: tap-googleads namespace: tap_googleads -pip_url: git+https://github.com/Matatika/tap-googleads.git@v0.5.0 +pip_url: git+https://github.com/Matatika/tap-googleads.git@v0.8.0 quality: gold repo: https://github.com/Matatika/tap-googleads settings: From 8d9921995ddada9fe384acebe77c64498c246481 Mon Sep 17 00:00:00 2001 From: Reuben Frankel Date: Tue, 22 Oct 2024 14:36:07 +0100 Subject: [PATCH 2/5] Update tap settings --- .../extractors/tap-googleads/matatika.yml | 40 ++++++++++++++++--- 1 file changed, 35 insertions(+), 5 deletions(-) diff --git a/_data/meltano/extractors/tap-googleads/matatika.yml b/_data/meltano/extractors/tap-googleads/matatika.yml index ffdd16c9d..7f19ff11f 100644 --- a/_data/meltano/extractors/tap-googleads/matatika.yml +++ b/_data/meltano/extractors/tap-googleads/matatika.yml @@ -46,17 +46,32 @@ settings: kind: string label: Batch Config Storage Root name: batch_config.storage.root -- description: Customer ID (Required) of the google ads account you want to sync data - from. - kind: password +- description: | + Get data for customers by the provided IDs. Defaults to all customers accessible to + the authenticated principal. + label: Customer IDs + name: customer_ids +- description: | + Get data for a customer by the provided ID. Defaults to all customers accessible to + the authenticated principal. label: Customer ID name: customer_id - sensitive: true - description: Developer Token (Required) - [Obtain your developer token](https://developers.google.com/google-ads/api/docs/first-call/dev-token) kind: password label: Developer Token name: developer_token sensitive: true +- description: | + Enable the click view report stream. Default to `false`. This requires certain + permissions to be set for your Google Ads account(s). + kind: boolean + label: Enable Click View Report Stream + name: enable_click_view_report_stream + value: false +- description: Date to sync data up to (ISO8601). Defaults to the current day. + kind: date_iso8601 + label: End Date + name: end_date - description: "'True' to enable schema flattening and automatically expand nested properties." kind: boolean @@ -66,6 +81,12 @@ settings: kind: integer label: Flattening Max Depth name: flattening_max_depth +- description: | + If authenticated as a manager account, `login_customer_id` should be set to the + customer ID of the manager account. Read about the [login customer ID concept](https://developers.google.com/search-ads/reporting/concepts/login-customer-id) + for more info. + label: Login Customer ID + name: login_customer_id - description: OAuth Client ID (Required) - [Obtain your credentials](https://developers.google.com/adwords/api/docs/guides/authentication) kind: password @@ -84,6 +105,11 @@ settings: label: OAuth Credentials Refresh Token name: oauth_credentials.refresh_token sensitive: true +- description: | + Date to sync data from (ISO8601). Defaults to 90 days before the current day. + kind: date_iso8601 + label: Start Date + name: start_date - description: User-defined config values to be used within map expressions. kind: object label: Stream Map Config @@ -93,5 +119,9 @@ settings: kind: object label: Stream Maps name: stream_maps -settings_group_validation: [] +settings_group_validation: +- - client_id + - client_secret + - developer_token + - refresh_token variant: matatika From 87a6484a0fa698e7175807a791bad7262bed44a5 Mon Sep 17 00:00:00 2001 From: ReubenFrankel <60552974+ReubenFrankel@users.noreply.github.com> Date: Tue, 22 Oct 2024 15:52:22 +0100 Subject: [PATCH 3/5] `customer_ids` should be an `array` MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Edgar Ramírez Mondragón <16805946+edgarrmondragon@users.noreply.github.com> --- _data/meltano/extractors/tap-googleads/matatika.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/_data/meltano/extractors/tap-googleads/matatika.yml b/_data/meltano/extractors/tap-googleads/matatika.yml index 7f19ff11f..716434141 100644 --- a/_data/meltano/extractors/tap-googleads/matatika.yml +++ b/_data/meltano/extractors/tap-googleads/matatika.yml @@ -49,6 +49,7 @@ settings: - description: | Get data for customers by the provided IDs. Defaults to all customers accessible to the authenticated principal. + kind: array label: Customer IDs name: customer_ids - description: | From 36342b8e4c122cf958a5416bcc5efd06f51e9409 Mon Sep 17 00:00:00 2001 From: Reuben Frankel Date: Tue, 22 Oct 2024 15:56:51 +0100 Subject: [PATCH 4/5] Hide legacy `customer_id` setting --- _data/meltano/extractors/tap-googleads/matatika.yml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/_data/meltano/extractors/tap-googleads/matatika.yml b/_data/meltano/extractors/tap-googleads/matatika.yml index 716434141..04da3a15d 100644 --- a/_data/meltano/extractors/tap-googleads/matatika.yml +++ b/_data/meltano/extractors/tap-googleads/matatika.yml @@ -46,17 +46,18 @@ settings: kind: string label: Batch Config Storage Root name: batch_config.storage.root +- description: | + Get data for a customer by the provided ID. Defaults to all customers accessible to + the authenticated principal. + hidden: true + label: Customer ID + name: customer_id - description: | Get data for customers by the provided IDs. Defaults to all customers accessible to the authenticated principal. kind: array label: Customer IDs name: customer_ids -- description: | - Get data for a customer by the provided ID. Defaults to all customers accessible to - the authenticated principal. - label: Customer ID - name: customer_id - description: Developer Token (Required) - [Obtain your developer token](https://developers.google.com/google-ads/api/docs/first-call/dev-token) kind: password label: Developer Token From b81b3b396aa7844c9af29c265957b671aa9d1e4c Mon Sep 17 00:00:00 2001 From: Reuben Frankel Date: Tue, 22 Oct 2024 16:43:01 +0100 Subject: [PATCH 5/5] Add deprecation notice for `customer_id` --- _data/meltano/extractors/tap-googleads/matatika.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/_data/meltano/extractors/tap-googleads/matatika.yml b/_data/meltano/extractors/tap-googleads/matatika.yml index 04da3a15d..22b2efded 100644 --- a/_data/meltano/extractors/tap-googleads/matatika.yml +++ b/_data/meltano/extractors/tap-googleads/matatika.yml @@ -47,6 +47,8 @@ settings: label: Batch Config Storage Root name: batch_config.storage.root - description: | + **DEPRECATED**: use `customer_ids` + Get data for a customer by the provided ID. Defaults to all customers accessible to the authenticated principal. hidden: true