Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[resolves #89] Add a configuration to set stash page size when comparing changes for change set #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[resolves #89] Add a configuration to set stash page size when comparing changes for change set #90

wants to merge 1 commit into from

Conversation

madappa-sharath
Copy link

Fixes #89

Proposed Changes

Stash compare changes rest api is paginated and only returns first 25 paths changed. In monorepos change set can be over 25 and the pipelines evaluated with partial change set can be inaccurate.

Provide a configuration to set higher page size limit.

Description

Added an environment config to specify page size and pass it onto GetStashFilesChanged if configured

Checklist

  • Read the CONTRIBUTING document.
  • Read the CODE OF CONDUCT document.
  • Add tests to cover changes.
  • Ensure your code follows the code style of this project.
  • Ensure CI and all other PR checks are green OR
    • Code compiles correctly.
    • Created tests which fail without the change (if possible).
    • All new and existing tests passed.
  • Add your changes to Unreleased section of CHANGELOG.
  • Improve and update the README (if necessary).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@madappa-sharath