You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've noticed that resetLoadingButton interferes with shinyjs functionalities in two ways:
button is hidden with shinyjs::hide -> resetLoadingButton shows it,
button is disabled with shinyjs::disable -> resetLoadingButton enables it. This behaviour is somehow by definition, but anyway could be confusing, because such a button still has disabled class and looks like disabled, but really it isn't.
The first behaviour is caused by resetLoadingButton restoring the initial style completely and hence dropping display: none, while the other by removing disabled attribute.
Both issues could probably be tackled in different way (at least in my case they could). However maybe it is possible to account for this, for example by performing reset only if a button is really in "loading" state (another attribute?), with an option to force hard reset? Hidden state could also be maintained by keeping style definition.
The text was updated successfully, but these errors were encountered:
I've noticed that
resetLoadingButton
interferes withshinyjs
functionalities in two ways:shinyjs::hide
->resetLoadingButton
shows it,shinyjs::disable
->resetLoadingButton
enables it. This behaviour is somehow by definition, but anyway could be confusing, because such a button still hasdisabled
class and looks like disabled, but really it isn't.This simple app demonstrates the problem.
The first behaviour is caused by
resetLoadingButton
restoring the initialstyle
completely and hence droppingdisplay: none
, while the other by removingdisabled
attribute.Both issues could probably be tackled in different way (at least in my case they could). However maybe it is possible to account for this, for example by performing reset only if a button is really in "loading" state (another attribute?), with an option to force hard reset? Hidden state could also be maintained by keeping style definition.
The text was updated successfully, but these errors were encountered: