Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Rearrange traceroute result and add some differentiating colour #1207

Open
1 task done
b8b8 opened this issue Aug 24, 2024 · 8 comments
Open
1 task done
Labels
enhancement New feature or request

Comments

@b8b8
Copy link

b8b8 commented Aug 24, 2024

Contact Details

No response

Tell us your idea.

My suggestion is to have the traceroutes present vertically and with different colours for hops, transmit, and receive. Also including the hopping SNR would be beneficial.
signal-2024-08-24-144701

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@b8b8 b8b8 added the enhancement New feature or request label Aug 24, 2024
@GUVWAF
Copy link
Member

GUVWAF commented Aug 25, 2024

Hey @b8b8, maybe it would be good to consider here how traceroute in 2.5 is going to look like in general. Apart from the SNR per hop, we can also get a two-way traceroute result. There is some validation needed, because it depends on the firmware of the nodes in the route whether the info is accurate or not. I opened a PR for the Python CLI (meshtastic/python#654) to accommodate for this; basically the length of the list of SNRs should be 1 longer than the route list and nodes and SNR can be unknown (represented by 0xFFFFFFFF and -128 respectively).

Maybe it can look something like this then (excuse me for my Paint skills):
traceroute_android

Not sure how feasible all of this is, but it would be cool to show it like this :)

@b8b8
Copy link
Author

b8b8 commented Aug 25, 2024

Dude this looks even better.

@cbvicious
Copy link

Is there any possibility to add timestamps to each hop? And/or how many attempts it took to make each hop? Could be useful for assessing where you need better coverage.

@Nestpebble
Copy link

I've already mentioned it in the discord, but apparently not asked for it as a feature request. Putting the results in the chat history for a node would solve some of the things people have asked for above

@b8b8
Copy link
Author

b8b8 commented Aug 25, 2024

I've already mentioned it in the discord, but apparently not asked for it as a feature request. Putting the results in the chat history for a node would solve some of the things people have asked for above

yea, how about the pop-up, but then also the pop-up results end up saved in the appropriate DM with text of all the info people are asking for. Pop just shows info GUVWAF posted. DM has all this plus any other info like timing as text.

@Nestpebble
Copy link

I've already mentioned it in the discord, but apparently not asked for it as a feature request. Putting the results in the chat history for a node would solve some of the things people have asked for above

yea, how about the pop-up, but then also the pop-up results end up saved in the appropriate DM with text of all the info people are asking for. Pop just shows info GUVWAF posted. DM has all this plus any other info like timing as text.

Yep. They're a bit ephemeral at the minute, even if they succeed after you switch tabs they're lost.

@GUVWAF
Copy link
Member

GUVWAF commented Aug 25, 2024

@cbvicious

Is there any possibility to add timestamps to each hop?

No, those are not sent over LoRa. It would also be hard to get valuable info from them, because each node uses random delays before transmitting and they might have other packets in their queue. Also nodes are not time-synchronized, at least not with second-level accuracy.

And/or how many attempts it took to make each hop?

Intermediate hops only ever try once. If the signal quality is strong and the traceroute fails, it's likely a packet collision.

@andrekir
Copy link
Member

andrekir commented Sep 1, 2024

the traceroute dialog message takes a String type, so more complex layouts are not possible. someone could add colors using SpannableString but that's a lot of work. priority for now is to add the new 2.5 round-trip/SNR information in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants