Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: "Alert Bell Character" button ignores message size limit #1511

Closed
1 task done
IlyaMZP opened this issue Dec 29, 2024 · 1 comment · Fixed by #1522
Closed
1 task done

[Bug]: "Alert Bell Character" button ignores message size limit #1511

IlyaMZP opened this issue Dec 29, 2024 · 1 comment · Fixed by #1522
Labels
bug Something isn't working

Comments

@IlyaMZP
Copy link

IlyaMZP commented Dec 29, 2024

Contact Details

[email protected]

What happened?

Pressing the "🔔 Alert Bell Character!" button multiple times can create a message larger than the 200 character limit which still can be sent.

App Version

2.5.15

Phone

OnePlus 8, Android 14

Device

heltec v3

Firmware

2.5.15.79da2365

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@IlyaMZP IlyaMZP added the bug Something isn't working label Dec 29, 2024
jamesarich added a commit to jamesarich/Meshtastic-Android that referenced this issue Jan 3, 2025
Limits quick chat append to 200 characters and prevents duplicate appends.
Also sets a constant for the max message size.

fixes meshtastic#1511
@jsoberg
Copy link
Contributor

jsoberg commented Feb 9, 2025

I also noticed testing this that you can't delete anything after hitting it past the character limit. We should likely just allow the user to enter > 200 characters and disable the send button so that they can't send - the character count in the text input should indicate what's wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants