Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Application specific tests for Dex #2899

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

SandhyaRavi2403
Copy link
Contributor

What problem does this PR solve?:

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@SandhyaRavi2403 SandhyaRavi2403 self-assigned this Dec 2, 2024
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 2, 2024
@coveralls
Copy link

coveralls commented Dec 2, 2024

Pull Request Test Coverage Report for Build 12238621205

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%

Totals Coverage Status
Change from base Build 12190303423: 0.0%
Covered Lines: 167
Relevant Lines: 323

💛 - Coveralls

@SandhyaRavi2403 SandhyaRavi2403 force-pushed the sandy/app-specific-test-dex branch from 3be34c5 to 7ecd3a6 Compare December 9, 2024 15:17
@SandhyaRavi2403 SandhyaRavi2403 requested review from mhrabovcin and lukeogg and removed request for mhrabovcin December 9, 2024 18:27
@SandhyaRavi2403
Copy link
Contributor Author

@lukeogg
I have replicated the tests for dex based on the existing one's. I could see the installation is failing
s: "helm release not ready yet",
Could you suggest on if anything needs to be added. Thanks

@lukeogg
Copy link
Contributor

lukeogg commented Dec 9, 2024

I'll slack you some ideas on what to do next. Looks like Dex, needs a valid certificate.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants