Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add valkey to harbor #3014

Merged
merged 4 commits into from
Jan 15, 2025
Merged

feat: add valkey to harbor #3014

merged 4 commits into from
Jan 15, 2025

Conversation

mhrabovcin
Copy link
Contributor

What problem does this PR solve?:
Adds HA valkey installation.

Which issue(s) does this PR fix?:

https://jira.nutanix.com/browse/NCN-104740

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@mhrabovcin mhrabovcin requested a review from jimmidyson January 15, 2025 11:39
@mhrabovcin mhrabovcin self-assigned this Jan 15, 2025
@mesosphere-ci mesosphere-ci added ok-to-test Signals mergebot that CI checks are ready to be kicked off update-licenses signals mergebot to update licenses.d2iq.yaml labels Jan 15, 2025
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 15, 2025
@mhrabovcin mhrabovcin removed the request for review from jimmidyson January 15, 2025 11:39
@coveralls
Copy link

coveralls commented Jan 15, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12791145347

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%
Totals Coverage Status
Change from base Build 12786181590: 0.0%
Covered Lines: 167
Relevant Lines: 323
💛 - Coveralls

jimmidyson
jimmidyson approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@jimmidyson jimmidyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jimmidyson jimmidyson enabled auto-merge (squash) January 15, 2025 15:03
@jimmidyson jimmidyson merged commit 181f1e0 into main Jan 15, 2025
22 checks passed
@jimmidyson jimmidyson deleted the mh/harbor-valkey branch January 15, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmidyson jimmidyson jimmidyson approved these changes

Assignees

@mhrabovcin mhrabovcin

Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off services/harbor size/L Denotes a PR that changes 100-499 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mhrabovcin @coveralls @jimmidyson @mesosphere-ci