Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: third-party apps should use the qualified certification #3027

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

nataliepina
Copy link
Contributor

@nataliepina nataliepina commented Jan 16, 2025

What problem does this PR solve?:
Third-party applications should use 'qualified' instead of 'supported'.
Supported is now reserved for Nutanix supported apps - NKP Insights, NAI, etc.

Which issue(s) does this PR fix?:

https://jira.nutanix.com/browse/NCN-105258

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

CloudNativePG and Harbor applications will have a qualified badge and not a certified badge.

Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@github-actions github-actions bot added services/harbor size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 16, 2025
@mesosphere-ci mesosphere-ci added ok-to-test Signals mergebot that CI checks are ready to be kicked off update-licenses signals mergebot to update licenses.d2iq.yaml labels Jan 16, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12813265114

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%

Totals Coverage Status
Change from base Build 12807820042: 0.0%
Covered Lines: 167
Relevant Lines: 323

💛 - Coveralls

Copy link
Contributor

@guillermoz-nutanix guillermoz-nutanix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree an app shouldn't have both supported/qualified.

The trick with Nutanix registry is that we are adding extra configuration to make it HA, eg, deploying PG and Valkey(Redis) as dependencies, so this is not an app that we simply bundle.

I'm not sure where the boundary between Qualified and Supported apps lives.

@nataliepina
Copy link
Contributor Author

I agree an app shouldn't have both supported/qualified.

The trick with Nutanix registry is that we are adding extra configuration to make it HA, eg, deploying PG and Valkey(Redis) as dependencies, so this is not an app that we simply bundle.

I'm not sure where the boundary between Qualified and Supported apps lives.

Yeah, I am following the notes from product on this. There may need to be further discussion around this.

@nataliepina nataliepina merged commit b50a65e into main Jan 17, 2025
60 checks passed
@nataliepina nataliepina deleted the remove-supported-from-new-apps branch January 17, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off services/harbor size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants