Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: drop cosi controller install #3035

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Conversation

takirala
Copy link
Contributor

@takirala takirala commented Jan 17, 2025

What problem does this PR solve?:

Depends on https://github.com/mesosphere/konvoy2/pull/3474 and https://github.com/mesosphere/konvoy2/pull/3521

Once konvoy is cosi ready with/without caren, we can revert the cosi controller deployment in kubecost. This will affect kind cluster CI (as it would be missing cosi controller) so we need to fix it in kommander repo before merging this change.

Which issue(s) does this PR fix?:

https://jira.nutanix.com/browse/NCN-105279
Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

Signed-off-by: Tarun Gupta Akirala <[email protected]>
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. services/kubecost labels Jan 17, 2025
@mesosphere-ci mesosphere-ci added ok-to-test Signals mergebot that CI checks are ready to be kicked off do-not-merge/testing Do not merge because there is still on-going testing open-kommander-pr Automatically triggers the creation of a PR in Kommander repo update-licenses signals mergebot to update licenses.d2iq.yaml labels Jan 17, 2025
Copy link
Contributor

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/tga/drop-cosi-controller

1 similar comment
Copy link
Contributor

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/tga/drop-cosi-controller

@coveralls
Copy link

coveralls commented Jan 17, 2025

Pull Request Test Coverage Report for Build 12915739740

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%

Totals Coverage Status
Change from base Build 12835417000: 0.0%
Covered Lines: 167
Relevant Lines: 323

💛 - Coveralls

Signed-off-by: Tarun Gupta Akirala <[email protected]>
@takirala takirala merged commit 217e5c5 into main Jan 22, 2025
22 checks passed
@takirala takirala deleted the tga/drop-cosi-controller branch January 22, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/testing Do not merge because there is still on-going testing ok-to-test Signals mergebot that CI checks are ready to be kicked off open-kommander-pr Automatically triggers the creation of a PR in Kommander repo services/kubecost size/M Denotes a PR that changes 30-99 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants