Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update all Essential License name under the kommander applicatio… #3045

Merged
merged 1 commit into from
Jan 21, 2025
Merged

fix: Update all Essential License name under the kommander applicatio… #3045

merged 1 commit into from
Jan 21, 2025

Conversation

johnliu25
Copy link
Contributor

@johnliu25 johnliu25 commented Jan 21, 2025 •
edited
Loading

Need to update the all kommander applications Essential license field from Essentials to Essential.

Example: https://github.com/mesosphere/kommander-applications/blob/main/services/grafana-logging/metadata.yaml#L13

JIRA: https://jira.nutanix.com/browse/NCN-105311

@johnliu25 johnliu25 requested a review from takirala January 21, 2025 18:10
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 21, 2025
@johnliu25 johnliu25 requested a review from cwyl02 January 21, 2025 18:10
@johnliu25 johnliu25 requested a review from mhrabovcin January 21, 2025 18:10
@mesosphere-ci mesosphere-ci added ok-to-test Signals mergebot that CI checks are ready to be kicked off do-not-merge/testing Do not merge because there is still on-going testing open-kommander-pr Automatically triggers the creation of a PR in Kommander repo update-licenses signals mergebot to update licenses.d2iq.yaml labels Jan 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/NCN-105311

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12893160747

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%
Totals Coverage Status
Change from base Build 12871382284: 0.0%
Covered Lines: 167
Relevant Lines: 323
💛 - Coveralls

@johnliu25 johnliu25 merged commit 5ed0965 into main Jan 21, 2025
847 of 849 checks passed
@johnliu25 johnliu25 deleted the NCN-105311 branch January 21, 2025 19:54
rohitkumar0510 pushed a commit that referenced this pull request Feb 5, 2025
@johnliu25 @rohitkumar0510
fix: Update all Essential License name under the kommander applicatio… (
b4a8f28 
#3045)

fix: Update all Essential License name under the kommander application metadata.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishankumarnutanix kishankumarnutanix kishankumarnutanix approved these changes

@cwyl02 cwyl02 cwyl02 approved these changes

@takirala takirala takirala approved these changes

@mhrabovcin mhrabovcin Awaiting requested review from mhrabovcin

@kaiwalyajoshi kaiwalyajoshi Awaiting requested review from kaiwalyajoshi

@deepakm-ntnx deepakm-ntnx Awaiting requested review from deepakm-ntnx

Assignees
No one assigned
Labels
do-not-merge/testing Do not merge because there is still on-going testing ok-to-test Signals mergebot that CI checks are ready to be kicked off open-kommander-pr Automatically triggers the creation of a PR in Kommander repo ready-for-review services/ai-navigator-app services/ai-navigator-cluster-info-agent services/cert-manager services/chartmuseum services/dex services/dex-k8s-authenticator services/external-dns services/fluent-bit services/gatekeeper services/git-operator services/grafana-logging services/grafana-loki services/harbor services/istio services/jaeger services/kiali services/knative services/kommander services/kommander-appmanagement services/kommander-flux services/kommander-ui services/kube-oidc-proxy services/kube-prometheus-stack services/kubefed services/kubernetes-dashboard services/kubetunnel services/logging-operator services/nkp-pulse-management services/nkp-pulse-workspace services/nvidia-gpu-operator services/prometheus-adapter services/reloader services/rook-ceph services/rook-ceph-cluster services/traefik services/traefik-forward-auth services/traefik-forward-auth-mgmt services/velero size/M Denotes a PR that changes 30-99 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@johnliu25 @coveralls @takirala @cwyl02 @kishankumarnutanix @mesosphere-ci