Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: track harbor generated secrets by flux #3051

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Conversation

mhrabovcin
Copy link
Contributor

What problem does this PR solve?:

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@mhrabovcin mhrabovcin requested a review from jimmidyson January 23, 2025 10:54
@mhrabovcin mhrabovcin self-assigned this Jan 23, 2025
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. services/harbor labels Jan 23, 2025
@mesosphere-ci mesosphere-ci added ok-to-test Signals mergebot that CI checks are ready to be kicked off update-licenses signals mergebot to update licenses.d2iq.yaml labels Jan 23, 2025
@coveralls
Copy link

coveralls commented Jan 23, 2025

Pull Request Test Coverage Report for Build 12927843982

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%

Totals Coverage Status
Change from base Build 12923017138: 0.0%
Covered Lines: 167
Relevant Lines: 323

💛 - Coveralls

Co-authored-by: Jimmi Dyson <jimmidyson@gmail.com>
@jimmidyson jimmidyson enabled auto-merge (squash) January 23, 2025 11:06
@jimmidyson jimmidyson merged commit 18c2b91 into main Jan 23, 2025
22 checks passed
@jimmidyson jimmidyson deleted the mh/harbor-secrets branch January 23, 2025 11:10
rohitkumar0510 pushed a commit that referenced this pull request Feb 5, 2025
* fix: track harbor generated secrets by flux

* chore: PR feedback

Co-authored-by: Jimmi Dyson <jimmidyson@gmail.com>

---------

Co-authored-by: Jimmi Dyson <jimmidyson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off services/harbor size/M Denotes a PR that changes 30-99 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants