Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add cosi controller image #3191

Merged
merged 2 commits into from
Feb 19, 2025
Merged

build: add cosi controller image #3191

merged 2 commits into from
Feb 19, 2025

Conversation

takirala
Copy link
Contributor

@takirala takirala commented Feb 19, 2025

What problem does this PR solve?:

cosi-driver-nutanix allows to install cosi controller image but this image is not added in licenses manifest. This is disabled by default and is handled by konvoy but I am adding it here for completeness (and also to make e2e tests easy on non konvoy clusters in airgapped env).

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

Signed-off-by: Tarun Gupta Akirala <[email protected]>
Signed-off-by: Tarun Gupta Akirala <[email protected]>
@takirala takirala self-assigned this Feb 19, 2025
@takirala takirala added the ok-to-test Signals mergebot that CI checks are ready to be kicked off label Feb 19, 2025
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. services/cosi-driver-nutanix labels Feb 19, 2025
@mesosphere-ci mesosphere-ci added the update-licenses signals mergebot to update licenses.d2iq.yaml label Feb 19, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13420638118

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%

Totals Coverage Status
Change from base Build 13400410244: 0.0%
Covered Lines: 167
Relevant Lines: 323

💛 - Coveralls

@takirala takirala added auto-backport backport-to-release-2.14 and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml services/cosi-driver-nutanix labels Feb 19, 2025
@takirala takirala merged commit 3e632f8 into main Feb 19, 2025
94 checks passed
@takirala takirala deleted the tga/add-cosi-image branch February 19, 2025 22:48
mesosphere-ci pushed a commit that referenced this pull request Feb 19, 2025
@mesosphere-ci
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
release-2.14

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

takirala added a commit that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport backport-to-release-2.14 ok-to-test Signals mergebot that CI checks are ready to be kicked off
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants