feat: adds conditional balance with check for swap #259
+29
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R-K-H
force-pushed
the
feat/extend-mint-swap-multi-balance
branch
2 times, most recently
from
cdc9081 to
a2df969
Compare
sdk/src/v0.3/FutarchyClient.ts
Outdated
| // Check to see if we need to mint conditional tokens | ||
| // If conditionalAmount is not passed we will mint all of the input amount | ||
| // If conditionalAmount is passed we will mint the difference between the input amount and the conditional amount | ||
| if (!conditionalAmount || (conditionalAmount && conditionalAmount.lt(inputAmount))) { |
There was a problem hiding this comment.
can be simplified to !conditionalAmount || conditionalAmount < inputAmount because if the first part evaluates to true the evaluation stops because it's an OR
There was a problem hiding this comment.
Got it, thanks! I was curious about that given null or undefined.
R-K-H
force-pushed
the
feat/extend-mint-swap-multi-balance
branch
from
a2df969 to
d01e8c6
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the mint and swap functionality to accept a conditional balance to be passed and either assigns a mint transaction or does not.
It is optional to pass this parameter, but if it does then it will ensure do dynamically mint if necessary.