Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad error reporting when the API secret or database is not found #105

Open
dtantsur opened this issue Dec 30, 2024 · 1 comment · May be fixed by #107
Open

Bad error reporting when the API secret or database is not found #105

dtantsur opened this issue Dec 30, 2024 · 1 comment · May be fixed by #107
Assignees
@dtantsur
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue is ready to be actively worked on.
Milestone
IrSO - v0.1

Comments

@dtantsur
Copy link
Member

In this case, the status will get stuck in

  status:                                                                                                                                                                                     
    conditions:                                                                                                                                                                               
    - lastTransitionTime: "2024-12-30T11:36:18Z"                                                                                                                                              
      message: new version requested                                                                                                                                                          
      observedGeneration: 1
      reason: DeploymentInProgress
      status: "False"
      type: Ready

with no indication what went wrong except for the manager logs. What we probably should do is to report the exact error via this condition. Something like

  status:                                                                                                                                                                                     
    conditions:                                                                                                                                                                               
    - lastTransitionTime: "2024-12-30T11:36:18Z"                                                                                                                                              
      message: cannot read the API credentials secret                                                                                                                                                         
      observedGeneration: 1
      reason: DeploymentFailed
      status: "False"
      type: Ready

Generally, error conditions in the operator need some love. Testing welcome.

/kind bug
/help
@dtantsur dtantsur added this to the IrSO MVP milestone Dec 30, 2024
@metal3-io-bot metal3-io-bot added kind/bug Categorizes issue or PR as related to a bug. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Dec 30, 2024
@dtantsur
Copy link
Member Author

dtantsur commented Jan 9, 2025

/assign
/triage accepted
/remove-help

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. and removed help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Jan 9, 2025
dtantsur added a commit to dtantsur/ironic-standalone-operator that referenced this issue Jan 9, 2025
@dtantsur
Rework error handling in the controller
f183789 
Currently, many error conditions are not reported on the Ironic object,
getting it stuck in e.g. "new version detected". This change makes
certain errors be reported in the status conditions. This includes
inability to find the database or the API secret, as well as validation
failures on the API secret.

Closes: metal3-io#105
Signed-off-by: Dmitry Tantsur <[email protected]>
@dtantsur dtantsur linked a pull request Jan 9, 2025 that will close this issue
Open
dtantsur added a commit to dtantsur/ironic-standalone-operator that referenced this issue Jan 9, 2025
@dtantsur
Rework error handling in the controller
5906bdf 
Currently, many error conditions are not reported on the Ironic object,
getting it stuck in e.g. "new version detected". This change makes
certain errors be reported in the status conditions. This includes
inability to find the database or the API secret, as well as validation
failures on the API secret.

Closes: metal3-io#105
Signed-off-by: Dmitry Tantsur <[email protected]>
dtantsur added a commit to dtantsur/ironic-standalone-operator that referenced this issue Jan 10, 2025
@dtantsur
Rework error handling in the controller
43c8c2c 
Currently, many error conditions are not reported on the Ironic object,
getting it stuck in e.g. "new version detected". This change makes
certain errors be reported in the status conditions. This includes
inability to find the database or the API secret, as well as validation
failures on the API secret.

Closes: metal3-io#105
Signed-off-by: Dmitry Tantsur <[email protected]>
dtantsur added a commit to dtantsur/ironic-standalone-operator that referenced this issue Jan 10, 2025
@dtantsur
Rework error handling in the controller
98e5059 
Currently, many error conditions are not reported on the Ironic object,
getting it stuck in e.g. "new version detected". This change makes
certain errors be reported in the status conditions. This includes
inability to find the database or the API secret, as well as validation
failures on the API secret.

Closes: metal3-io#105
Signed-off-by: Dmitry Tantsur <[email protected]>
dtantsur added a commit to dtantsur/ironic-standalone-operator that referenced this issue Jan 10, 2025
@dtantsur
Rework error handling in the controller
f4a035c 
Currently, many error conditions are not reported on the Ironic object,
getting it stuck in e.g. "new version detected". This change makes
certain errors be reported in the status conditions. This includes
inability to find the database or the API secret, as well as validation
failures on the API secret.

Closes: metal3-io#105
Signed-off-by: Dmitry Tantsur <[email protected]>
dtantsur added a commit to dtantsur/ironic-standalone-operator that referenced this issue Jan 10, 2025
@dtantsur
Rework error handling in the controller
a9a3f10 
Currently, many error conditions are not reported on the Ironic object,
getting it stuck in e.g. "new version detected". This change makes
certain errors be reported in the status conditions. This includes
inability to find the database or the API secret, as well as validation
failures on the API secret.

The database link does pose a UX problem right now: it's not possible to
change it once it's set. I will leave this as a known issue for now.

Closes: metal3-io#105
Signed-off-by: Dmitry Tantsur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dtantsur dtantsur

Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
None yet
Milestone
IrSO - v0.1
Development

Successfully merging a pull request may close this issue.

🐛 Rework error handling in the controller dtantsur/ironic-standalone-operator
2 participants
@dtantsur @metal3-io-bot