🐛 Rework error handling in the controller #107
+149
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
size/M
metal3-io-bot
added
size/L
dtantsur
force-pushed
the
error
branch
2 times, most recently
from
43c8c2c to
98e5059
Compare
dtantsur
changed the title
metal3-io-bot
removed
the
do-not-merge/work-in-progress
Currently, many error conditions are not reported on the Ironic object, getting it stuck in e.g. "new version detected". This change makes certain errors be reported in the status conditions. This includes inability to find the database or the API secret, as well as validation failures on the API secret. The database link does pose a UX problem right now: it's not possible to change it once it's set. I will leave this as a known issue for now. Closes: metal3-io#105 Signed-off-by: Dmitry Tantsur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, many error conditions are not reported on the Ironic object,
getting it stuck in e.g. "new version detected". This change makes
certain errors be reported in the status conditions. This includes
inability to find the database or the API secret, as well as validation
failures on the API secret.
The database link does pose a UX problem right now: it's not possible to
change it once it's set. I will leave this as a known issue for now.
Closes: #105
Signed-off-by: Dmitry Tantsur [email protected]