Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass CA certificates in addition to just key/certificate #90

Open
dtantsur opened this issue Nov 27, 2024 · 5 comments
Open

Pass CA certificates in addition to just key/certificate #90

dtantsur opened this issue Nov 27, 2024 · 5 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue is ready to be actively worked on.
Milestone

Comments

@dtantsur
Copy link
Member

Probably turn the current tlsRef into a structure:

spec:
  tls:
    certRef:
      name: ironic-cert
    caRef:
      name: ironic-ca-cert

Where caRef is optional.

/kind feature
/help

@dtantsur dtantsur added this to the IrSO MVP milestone Nov 27, 2024
@metal3-io-bot metal3-io-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 27, 2024
@metal3-io-bot
Copy link
Contributor

@dtantsur:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

Probably turn the current tlsRef into a structure:

spec:
 tls:
   certRef:
     name: ironic-cert
   caRef:
     name: ironic-ca-cert

Where caRef is optional.

/kind feature
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Nov 27, 2024
@dtantsur
Copy link
Member Author

See #91 for an important naming discussion.

@Rozzii
Copy link
Member

Rozzii commented Dec 4, 2024

/triage accepted

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Dec 4, 2024
@winiciusallan
Copy link
Contributor

Hi @dtantsur! This issue is still valid, considering the discussion in #91 ?

@dtantsur
Copy link
Member Author

Hi. This issue is potentially valid still, just with different naming (caName vs caRef). I personally don't have a use case for passing a CA but folks might.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants