Looks like these no longer have to be Options, no? 👀

@Razz4780 think it does because PathBuf can either be Some (if -f is provided with or without a value) and None (-f is not provided at all). When we use default_value instead of default_missing_value then we wouldn't need Option because there would always be Some value which is the default value we pass to default_value. default_missing_value checks if -f has a value. If it does not then it uses ./mirrord.json as the argument to the -f flag.

Let me know if I am making sense.

Looks like these no longer have to be Options, no? 👀

@Razz4780 think it does because PathBuf can either be Some (if -f is provided with or without a value) and None (-f is not provided at all). When we use default_value instead of default_missing_value then we wouldn't need Option because there would always be Some value which is the default value we pass to default_value. default_missing_value checks if -f has a value. If it does not then it uses ./mirrord.json as the argument to the -f flag.

Let me know if I am making sense.

Ah yes, this is correct. Sorry for confusion

@t4lz

1. I will update the default path to be the same then.

2. I tested this PR with -f my-mirrord-config.json like config with the following command

./target/universal-apple-darwin/debug/mirrord exec -f ./my-mirrord-mirrord.json -t deployment/kotlin-guestbook bash

and it works, don't believe this will break the existing user experience. I will add a test just in case

@t4lz @Razz4780 PR has been updated 🫡