Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] TYPO3 12: Collecting response message #41

Open
3l73 opened this issue Oct 2, 2024 · 0 comments
Open

[Bug] TYPO3 12: Collecting response message #41

3l73 opened this issue Oct 2, 2024 · 0 comments

Comments

@3l73
Copy link

3l73 commented Oct 2, 2024

The extension uses the class \Crossmedia\Fourallportal\Response\CollectingResponse handle the output in CLI and backend context.

The class itself is an inheritance of \Symfony\Component\Console\Command\Command which does not makes sense, since it is not an command and used only to collect message data.

The class should implement the interface \TYPO3\CMS\Core\Collection\CollectionInterface and remove the dependency to \Symfony\Component\Console\Command\Command.

Additionally, a method add(string ...$line): void should be added and replace the method setDescription(string $description).

The output within a command or controller can be done by walking threw the Collection.

Implementing the interface \Stringable would allow to concat the lines into a single string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant