TYPO3 12: RelatedModuleViewHelper access to non existing variable $relations

[3l73]

The ViewHelper RelatedModuleViewHelper uses the variable $relations to retrieve relations.

In case of exceptions the variable is not set which can leads to errors or at least warnings.

crossmedia_fourallportal/Classes/ViewHelpers/RelatedModuleViewHelper.php

Line 90 in 3e00a60

$variableProvider->add('relations', $relations['result']);

The variable should be initialized in order to avoid warnings.

   $relations = [
       'result' => [].
   ];
    try {
      // Make an attempt with the FIRST configured dimension mapping enabled. The first entry SHOULD always be the default language.
      $fieldValue = (new ResponseDataFieldValueReader())->readResponseDataField($response['result'][0], $field, $module->getServer()->getDimensionMappings()->current());
      if ($fieldValue != null) {
        $relations = ['result' => (array)$fieldValue];
        if ($arguments['verifyRelations']) {
          $relations = $module->getServer()->getClient()->getBeans($fieldValue, $relatedModule->getConnectorName());
        }
      }
    } catch (\RuntimeException $error) {
      $fieldValue = $error->getMessage();
    } catch (PropertyNotAccessibleException $error) {
      $fieldValue = $error->getMessage();
    }