Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify our linting strategy with aspect's rules_lint for linting #125

Open
michael-christen opened this issue Sep 22, 2024 · 0 comments
Open

Comments

@michael-christen
Copy link
Owner

michael-christen commented Sep 22, 2024

https://blog.aspect.build/lint

https://github.com/aspect-build/rules_lint

(2024-11-10)
We're starting to use this in #138. This issue should switch to tracking the work necessary to "unify" our linting approaches.

@michael-christen michael-christen changed the title Try out aspect's rules_lint for linting Unify our linting strategy with aspect's rules_lint for linting Nov 10, 2024
michael-christen added a commit that referenced this issue Nov 10, 2024
Start to setup clang-format using rules_lint:
https://github.com/aspect-build/rules_lint

We should have a followup to consolidate our linting / formatting tools.
this does get us setup for C++ (which will be enabled in a followup).
See #125

Also, added a `--config local` for bazel to avoid remote caching, etc.
to avoid network latency when my home network is slow.
michael-christen added a commit that referenced this issue Nov 12, 2024
This is the culmination of several PRs, allowing us to bind this service
to this app.

See
#155 (comment)
for my log of notes along the way.

Here are the related PRs:
- #153 
- #152 
- #151 
- #150 
- #143 
- #142 
- #141 
- #140 
- #138 

And the created/related issues:
- #154 
- #149 
- #148
- #147 
- #145 
- #144 
- #139 
- #125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant