Add clang-format #138
Merged
Add clang-format #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #138 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 56 56
=========================================
Hits 56 56 |
Merged
michael-christen
added a commit
that referenced
this pull request
Nov 12, 2024
This is the culmination of several PRs, allowing us to bind this service to this app. See #155 (comment) for my log of notes along the way. Here are the related PRs: - #153 - #152 - #151 - #150 - #143 - #142 - #141 - #140 - #138 And the created/related issues: - #154 - #149 - #148 - #147 - #145 - #144 - #139 - #125
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start to setup clang-format using rules_lint: https://github.com/aspect-build/rules_lint
We should have a followup to consolidate our linting / formatting tools. this does get us setup for C++ (which will be enabled in a followup). See #125
Also, added a
--config localfor bazel to avoid remote caching, etc. to avoid network latency when my home network is slow.