Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow tabs for indentation #26

Open
prez opened this issue Dec 1, 2019 · 2 comments
Open

Allow tabs for indentation #26

prez opened this issue Dec 1, 2019 · 2 comments
Labels
extension Request for feature not present in ninja

Comments

@prez
Copy link

prez commented Dec 1, 2019

Currently, attempting to indent key = value pairs with tabs causes expected name errors, which is counter-intuitive. Especially considering that tabs are valid whitespace for line continuation.

The Ninja devs seem to be ignoring this (ninja-build/ninja#1598).

If there is a good reason to reject this, please consider raising an appropriate error message.

Thank you.
@michaelforney
Copy link
Owner

Yes, I think that would be quite nice to have, and I see no reason why allowing them would be a problem. Although scripts that use tabs would be incompatible with ninja.

This should be an easy change.

@michaelforney michaelforney added the extension Request for feature not present in ninja label May 5, 2021
@pkitszel
Copy link

Let's see how ninja will receive my PR
ninja-build/ninja#2392
it's just lexer change at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
extension Request for feature not present in ninja
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@michaelforney @prez @pkitszel