Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update local debugging for RBAC key vaults #4133

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

tim-allen-ck
Copy link
Collaborator

Resolves #4000

What is being addressed

Missed key vault policy in setup_local_debugging.sh

How is this addressed

  • keyvault_resource_id output added in core
  • script changed to add user as Key Vault Secrets User

Copy link

github-actions bot commented Nov 12, 2024

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit b2ecc12.

♻️ This comment has been updated with latest results.

Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you could get the keyvault resource ID, from the keyvault_name that already exists in the outputs via the CLI?

az keyvault show -n kv-mr0110-ws-d8ab --query id

@tim-allen-ck
Copy link
Collaborator Author

tim-allen-ck commented Nov 12, 2024

LGTM, you could get the keyvault resource ID, from the keyvault_name that already exists in the outputs via the CLI?

az keyvault show -n kv-mr0110-ws-d8ab --query id

yeah I thought about that, figured it was an unnecessary az command when we can get it from the tf

@tim-allen-ck
Copy link
Collaborator Author

/test-force-approve

Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit b2ecc12)

(in response to this comment from @tim-allen-ck)

@tim-allen-ck tim-allen-ck merged commit 897f1b1 into microsoft:main Nov 12, 2024
12 checks passed
@tim-allen-ck tim-allen-ck deleted the local_debug_fix branch November 12, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Key Vaults should use RBAC instead of access policies for access control
4 participants