From 35902c2e77c1a8b2c07b769a8825e322bf85648e Mon Sep 17 00:00:00 2001 From: Jake Bailey <5341706+jakebailey@users.noreply.github.com> Date: Mon, 30 Sep 2024 17:34:08 -0700 Subject: [PATCH] Remove references to tsserverlibrary.d.ts baseline from workflows (#60109) --- .github/workflows/new-release-branch.yaml | 2 -- .github/workflows/pr-modified-files.yml | 3 +-- .github/workflows/set-version.yaml | 2 -- 3 files changed, 1 insertion(+), 6 deletions(-) diff --git a/.github/workflows/new-release-branch.yaml b/.github/workflows/new-release-branch.yaml index 0ec3334920b5f..1ac0e6d812844 100644 --- a/.github/workflows/new-release-branch.yaml +++ b/.github/workflows/new-release-branch.yaml @@ -68,7 +68,6 @@ jobs: sed -i -e 's/"version": ".*"/"version": "${{ inputs.package_version }}"/g' package.json sed -i -e 's/const versionMajorMinor = ".*"/const versionMajorMinor = "${{ inputs.core_major_minor }}"/g' src/compiler/corePublic.ts sed -i -e 's/const versionMajorMinor = ".*"/const versionMajorMinor = "${{ inputs.core_major_minor }}"/g' tests/baselines/reference/api/typescript.d.ts - sed -i -e 's/const versionMajorMinor = ".*"/const versionMajorMinor = "${{ inputs.core_major_minor }}"/g' tests/baselines/reference/api/tsserverlibrary.d.ts sed -i -e 's/const version\(: string\)\{0,1\} = .*;/const version = "${{ inputs.package_version }}" as string;/g' src/compiler/corePublic.ts npm ci npm install # update package-lock.json to ensure the version bump is included @@ -78,7 +77,6 @@ jobs: git add package.json package-lock.json git add src/compiler/corePublic.ts git add tests/baselines/reference/api/typescript.d.ts - git add tests/baselines/reference/api/tsserverlibrary.d.ts git add --force ./lib git config user.email "typescriptbot@microsoft.com" git config user.name "TypeScript Bot" diff --git a/.github/workflows/pr-modified-files.yml b/.github/workflows/pr-modified-files.yml index 1784558ec02bb..c15cd48d19b98 100644 --- a/.github/workflows/pr-modified-files.yml +++ b/.github/workflows/pr-modified-files.yml @@ -120,8 +120,7 @@ jobs: - name: Check for breaking changes run: | - if ./is_changed.sh "tests/baselines/reference/api/typescript.d.ts" \ - "tests/baselines/reference/api/tsserverlibrary.d.ts"; then + if ./is_changed.sh "tests/baselines/reference/api/typescript.d.ts"; then MESSAGE="Looks like you're introducing a change to the public API surface area." MESSAGE+=" If this includes breaking changes, please document them" MESSAGE+=" [on our wiki's API Breaking Changes page](https://github.com/microsoft/TypeScript/wiki/API-Breaking-Changes)." diff --git a/.github/workflows/set-version.yaml b/.github/workflows/set-version.yaml index cf96e07ef7d36..2237c87c6428b 100644 --- a/.github/workflows/set-version.yaml +++ b/.github/workflows/set-version.yaml @@ -72,7 +72,6 @@ jobs: sed -i -e 's/"version": ".*"/"version": "${{ inputs.package_version }}"/g' package.json sed -i -e 's/const versionMajorMinor = ".*"/const versionMajorMinor = "${{ inputs.core_major_minor }}"/g' src/compiler/corePublic.ts sed -i -e 's/const versionMajorMinor = ".*"/const versionMajorMinor = "${{ inputs.core_major_minor }}"/g' tests/baselines/reference/api/typescript.d.ts - sed -i -e 's/const versionMajorMinor = ".*"/const versionMajorMinor = "${{ inputs.core_major_minor }}"/g' tests/baselines/reference/api/tsserverlibrary.d.ts sed -i -e 's/const version\(: string\)\{0,1\} = .*;/const version = "${{ inputs.package_version }}" as string;/g' src/compiler/corePublic.ts npm ci npm install # update package-lock.json to ensure the version bump is included @@ -82,7 +81,6 @@ jobs: git add package.json package-lock.json git add src/compiler/corePublic.ts git add tests/baselines/reference/api/typescript.d.ts - git add tests/baselines/reference/api/tsserverlibrary.d.ts git add --force ./lib git config user.email "typescriptbot@microsoft.com" git config user.name "TypeScript Bot"