Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Mixed Tabs could regard current editor preference #129

Open
ygoe opened this issue Apr 21, 2017 · 2 comments · May be fixed by #256
Open

Fix Mixed Tabs could regard current editor preference #129

ygoe opened this issue Apr 21, 2017 · 2 comments · May be fixed by #256

Comments

@ygoe
Copy link

ygoe commented Apr 21, 2017

Instead of leaving it up to the user to tabify or untabify the entire document in the case of inconsistencies, the add-on could regard the current editor preference and just "correct" indentation.

Background: We use tabs for indenting almost everything. (That's what they're made for.) But some files don't support this, like YAML. If you're used to hitting the "tabify" button, the YAML file will be broken. The editor can be set up correctly using EditorConfig or other local IDE configuration, but this add-on doesn't care about all the automatisms we now have.

Also, when working in other projects that request a different indentation style, this can be automatically provided by a .editorconfig file in the repository, but this add-on still wants me to decide manually.
@justcla
Copy link
Contributor

justcla commented Apr 21, 2017

Nice suggestion.

@ygoe
Copy link
Author

ygoe commented Apr 22, 2017

I've implemented this in my fork, kind of. The only thing that happens is that the Tabify or Untabify button is set to bold font, depending on the current editor preference. This seems alright for me now. It would be easy to actually add a "Correct as default" button, it just takes more space.

My commit is here, based on the other one I did before.

@workgroupengineering workgroupengineering linked a pull request Nov 15, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Allow to detect editor preference workgroupengineering/VS-PPT
2 participants
@ygoe @justcla