Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fundatmental issue - __cplusplus_winrt != UWP #1318

Open
mediabuff opened this issue Jan 30, 2020 · 2 comments · Fixed by microsoft/vcpkg#33768
Open

fundatmental issue - __cplusplus_winrt != UWP #1318

mediabuff opened this issue Jan 30, 2020 · 2 comments · Fixed by microsoft/vcpkg#33768

Comments

@mediabuff
Copy link

The library has genesis with support of C++/CX and assumes UWP is C++/CX and is replete with __cplusplus_winrt.

Which should'nt be the case as there are other c++ variants like cppwinrt. How do leverage this lib in cppwinrt context - and yet be binding to UWP apis not win32 apis.

Should this library code be converted from

#if __cplusplus_winrt
#endif

to

#if WINAPI_FAMILY_PARTITION(WINAPI_PARTITION_PC_APP)
#endif
@BrennanConroy
Copy link
Member

Looks like this issue prevents microsoft-signalr from using the cpprestsdk on UWP.

@autoantwort
Copy link

I think it should be

#if WINAPI_FAMILY == WINAPI_FAMILY_PC_APP
#endif

since __cplusplus_winrt means UWP only while WINAPI_FAMILY_PARTITION(WINAPI_PARTITION_PC_APP) is UWP + Desktop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants