[cpprestsdk] fix uwp #33768
Merged
[cpprestsdk] fix uwp #33768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autoantwort
force-pushed
the
cpprestsdk-uwp
branch
from
8bc8f51 to
ee32921
Compare
JonLiu1993
added
category:port-update
JonLiu1993
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/cpprestsdk#1318
I had the same problem with
microsoft-signalr. currently you have to build with/ZWso that__cplusplus_winrtis defined (https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170), butmicrosoft-signalrdoes not use/ZWso is does not detect UWP.The patch was created by search & replace + check that is does the right thing.