-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proxy support for OSX #83
Comments
Yes, I am interested in proxy support with basic authentication on OSX. On Fri, Mar 4, 2016 at 10:38 PM, Michal Vašíček [email protected]
|
Yes, this sounds like a solid feature. Can this be implemented under the existing public APIs, or would it need new ones? |
It is implemented in existing public API. It is implemented the same way as WIN transport layer. I added new file http_client_apple.cpp which is used on OSX (by CMAKE) instead of http_client_asio.cpp. It can be seen at https://github.com/mivasi/cpprestsdk/tree/macosx_client. There is still some minimal work to be done, because I disabled about 5 tests which do not pass yet. Also there are still some questions to be answered. For example, how to write proxy authentication tests for everyone. For now I wrote those tests depending on my local proxy server, but they fail to anyone else. |
Slightly off topic, but we also need to support NTLM (+negotiate) on windows for proxy authentication. |
Forgot to follow up, regardless, here's that link to my pull request within WebSocket++ (Pluggable Authenticated Proxy Support - with an implementation for Windows, supporting NTLM+Negotiate): |
@mivasi Did you consider contributing this as a pull request? A native OSX client would be a great addition. |
@deeringc I am sorry I still can't get all automations to pass which is the reason why I didn't make pull request yet. If someone can help me with that it would be great. I think code is ready and we are using it in production version of our product, but there are some minor automation failures I do not know what to do with them. |
I have a question if someone is interested in proxy support on OSX. I saw that you integrated basic linux proxy support which works on OSX too, but as I saw it has only basic authentication support. For our project it is not enough so we wrote native OSX transport layer which now supports basic and digest authentication and we are heading toward NTLM authentication type.
The text was updated successfully, but these errors were encountered: