-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
promptfoo / redteam #1114
promptfoo / redteam #1114
Conversation
Updated callApi to include an options parameter for flexibility.
The changes look good! Here's a breakdown of the analysis:
Minor Concern: The presence of duplicate "jailbreak" strategy option in both The changes:
LGTM 🚀
|
Introduced a redteam boolean to enhance configuration options.
Added `languages` property and improved deduplication via `uniq`.
add JS source to purpose |
Enhanced CLI commands, added test max concurrency constant.
Added rendering for 'purpose' in prompts, refined MarkdownTrace, updated redteam strategies and numTests, and expanded PromptScript types.
Updated CLI to support "eval" as alias for the "test" command.
- Removed unnecessary redteam plugins and strategies from the script.
@@ -85,7 +85,7 @@ Options: | |||
## `test` | |||
|
|||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command usage should be consistent. Consider using a single pipe symbol (|
) to separate the commands for clarity.
AI-generated content by pr-docs-review-commit
command_usage
may be incorrect
@@ -109,6 +109,7 @@ Arguments: | |||
are tested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Options should be grouped logically and consistently ordered. Consider moving --redteam
options closer to their respective commands.
AI-generated content by pr-docs-review-commit
option_order
may be incorrect
@@ -147,6 +148,7 @@ Usage: genaiscript test list [options] | |||
List available tests in workspace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Options should be grouped logically and consistently ordered. Consider moving --redteam
options closer to their respective commands.
AI-generated content by pr-docs-review-commit
option_order
may be incorrect
Added ci-info library and prompts for CI-specific decisions. Enhanced logging.
Changes Overview for Pull Request
Red Teaming Features Enhanced:
Introduced new constants
REDTEAM: "contracts"
in anOptionsOrString
enum, enabling red team strategies like "harmful" content detection.Message Generation Functionality Expanded:
Added a variable renamed from
messageBody
to include red team attack vector handling, facilitating customizable message templates for cybersecurity scenarios.User-Facing API Documentation Updated:
Included JSDOC-style comments in the test file to outline API endpoints and their functionalities, ensuring developers understand the user-facing API changes thoroughly.
These updates enhance the component's security capabilities while improving documentation quality, benefiting both internal development practices and external API consumers.