Enhance workspace.findFiles to Support Absolute Paths with Ignore Patterns

[anrgct]

Does workspace.findFiles not support absolute paths? Can the API be modified to support absolute paths while also allowing the input of ignore patterns? This method is very convenient for retrieving files.

const allFiles = await workspace.findFiles("/Users/anrgct/workspace/genaiscript/packages/sample/genaisrc/samples/**/*.{js,mjs,ts,mts}")
// path should be a `path.relative()`d string, but got "/Users/anrgct/workspace/genaiscript/packages/cli/src/worker.ts"

[github-actions]

@username

The current implementation of workspace.findFiles indeed expects relative paths rather than absolute paths, which can be limiting when dealing with deep directory structures.

To address this need, we could enhance the API to accept both relative and absolute paths. Additionally, it would be beneficial to include support for ignore patterns to filter out unwanted files or directories during the search.

Here’s a potential enhancement:

const allFiles = await workspace.findFiles(
  {
    "include": "/Users/anrgct/workspace/genaiscript/packages/sample/genaisrc/samples/**/*.{js,mjs,ts,mts}",
    "ignore": "**/.git/**,**/node_modules/**"
  }
);

This revised method would allow you to specify both include and ignore patterns and could handle absolute paths seamlessly. We should also ensure that the documentation reflects these changes clearly.

Thoughts?

AI-generated content by issue-reviewer may be incorrect

[pelikhan]

The limitation to relative files is technical debt from when we ran inside VSCode using the virtualized workspace file system; there's no real reason to be limited to relative paths anymore.

[pelikhan]

The latest version supports settings a "ignore" option which is fed into the ignore package.

[pelikhan]

• docs