OData WebAPI, RequestBuilderGetQueryParameters Count property type has typo

[pschmerling]

What are you generating using Kiota, clients or plugins?

API Client/SDK

In what context or format are you using Kiota?

Windows executable

Client library/SDK language

Csharp

Describe the bug

I generate an SDK using kiota commandline on a .NET 8 WebAPI with OData. The resulting source code cannot be compiled because of typo in every class named RequestBuilder > RequestBuilderGetQueryParameters.
Integer or boolean properties have the type written in camel-case - which is not valid c#. For example Int instead of int, Bool instead of bool. String properties are ok.
swagger.json
Produces AdditionalMatterResponsiblesRequestBuilder.cs containing class AdditionalMatterResponsiblesRequestBuilderGetQueryParameters, which contains

/// <summary>Adds count property</summary>
[QueryParameter("%24count")]
public Bool? Count { get; set; }

/// <summary>Number of objects to skip in the current order (ex. 50)</summary>
[QueryParameter("%24skip")]
public Int? Skip { get; set; }

/// <summary>Number of objects to return. (ex. 25)</summary>
[QueryParameter("%24top")]
public Int? Top { get; set; }

I tried to find the appropriate code in the kiota-source. Please correct me if I am wrong. Is the TranslateType (src/Kiota.Builder/Writers/CSharp/CSharpConventionService.cs) method missing the two cases for "int" and "bool"?

Expected behavior

RequestBuilder > RequestBuilderGetQueryParameters. The type int and bool must be written in lower-case.

How to reproduce

kiota commandline on a .NET 8 WebAPI with OData

Open API description file

swagger.json

Kiota Version

1.15.0

[baywet]

Hi @pschmerling
Thanks for using kiota and for reaching out.
I'm not exactly sure why your description is getting generated this way, it's invalid.
"int" parameters should be "integer"
"bool" parameters should be "boolean".
Feeding the description you've provided to spectral will give many "Value is not accepted. Valid values: "array", "boolean", "integer", "number", "object", "string"" errors.
I suggest that you reach out to the owners of the library you use to generate the description.

[pschmerling]

Hi @baywet
Thank you so much for your answer. You pointed me to the right direction. Because Swashbuckle for asp.net core is not able to detect the parameters of an EnabledQuery endpoint at all, I had to do this manually using an OperationFilter. I corrected the parameter-generation in this OperationFilter.

...
if (enableQueryAttribute.AllowedQueryOptions.HasFlag(AllowedQueryOptions.Count)) {
    operation.Parameters.Add(new OpenApiParameter() {
        Name = "$count",
        In = ParameterLocation.Query,
        Schema = new OpenApiSchema {
            Type = "boolean", // previously "bool"
        },
        Description = "Adds count property",
        Required = false
    });
}

if (enableQueryAttribute.AllowedQueryOptions.HasFlag(AllowedQueryOptions.Top)) {
    operation.Parameters.Add(new OpenApiParameter() {
        Name = "$top",
        In = ParameterLocation.Query,
        Schema = new OpenApiSchema {
            Type = "integer", // previously "int"
        },
        Description = "Number of objects to return. (ex. 25)",
        Required = false
    });
}

if (enableQueryAttribute.AllowedQueryOptions.HasFlag(AllowedQueryOptions.Skip)) {
    operation.Parameters.Add(new OpenApiParameter() {
        Name = "$skip",
        In = ParameterLocation.Query,
        Schema = new OpenApiSchema {
            Type = "integer", // previously "int"
        },
        Description = "Number of objects to skip in the current order (ex. 50)",
        Required = false
    });
}
...

Now the generated description is validating successfully in spectral - thank you for this hint, too.

[andrueastman]

Thanks for confirming @pschmerling

We'll close this one for now as there's no action on our side. Feel free to re-open or create new issue in the event of anything else.